The first author should be the one who does MOST of the writing, and who coordinates the work of the other authors.
This is usually not the role of faculty advisors.
I know senior faculty who always help their students receive their first journal publication, which is very beneficial, I believe, but the student should get the first author credit.